Skip to content

Add support for building rubik image#2110

Merged
samfreund merged 29 commits intoPhotonVision:mainfrom
samfreund:build-rubik-image
Oct 13, 2025
Merged

Add support for building rubik image#2110
samfreund merged 29 commits intoPhotonVision:mainfrom
samfreund:build-rubik-image

Conversation

@samfreund
Copy link
Member

@samfreund samfreund commented Oct 8, 2025 •
edited
Loading

We can build an image for the Rubik Pi 3!

Image is about 1.6 GB.

It got speedy 😄 (15m)

closes #2061

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@samfreund samfreund requested a review from a team as a code owner October 8, 2025 22:41
samfreund
samfreund commented Oct 8, 2025
View reviewed changes
samfreund
samfreund commented Oct 8, 2025
View reviewed changes
@samfreund

This comment was marked as duplicate.

Sign in to view
@samfreund samfreund mentioned this pull request Oct 8, 2025
Merged
7 tasks
@samfreund

This comment was marked as resolved.

Sign in to view
samfreund
samfreund commented Oct 10, 2025
View reviewed changes
@samfreund
Copy link
Member Author

samfreund commented Oct 10, 2025 •
edited
Loading

Oh my gawd it works

To be completed

@samfreund samfreund force-pushed the build-rubik-image branch 2 times, most recently from 239c0bc to 669c4e2 Compare October 10, 2025 19:54
@samfreund
Copy link
Member Author

samfreund commented Oct 10, 2025

This should be good to go, we're just waiting on a new release in https://github.com/photonvision/photon-image-modifier

@samfreund samfreund requested a review from mcm001 October 11, 2025 01:18
@samfreund samfreund requested review from crschardt and mcm001 October 12, 2025 06:30
@samfreund
Copy link
Member Author

samfreund commented Oct 12, 2025

We should probably cut a new version again in https://github.com/photonvision/photon-image-modifier before we merge this. There's also a weird bug I wanna try and iron out if possible that seems to have something to do with networking.

@samfreund
Copy link
Member Author

samfreund commented Oct 12, 2025

We should probably cut a new version again in photonvision/photon-image-modifier before we merge this. There's also a weird bug I wanna try and iron out if possible that seems to have something to do with networking.

Figured out the bug, it's not actually a bug. Ready to merge once image-modifier is good.

@mcm001
Copy link
Contributor

mcm001 commented Oct 12, 2025

Cut a new release against image modifier before merging?

@samfreund
Copy link
Member Author

samfreund commented Oct 12, 2025

Don't merge yet, I wanna do one last test.

@samfreund
Copy link
Member Author

samfreund commented Oct 12, 2025

@mcm001 tested and I'm satisfied

mcm001
mcm001 previously approved these changes Oct 12, 2025
View reviewed changes
mcm001
mcm001 previously approved these changes Oct 13, 2025
View reviewed changes
@samfreund samfreund merged commit 7979368 into PhotonVision:main Oct 13, 2025
41 checks passed
@samfreund samfreund deleted the build-rubik-image branch October 13, 2025 22:56
spacey-sooty pushed a commit to spacey-sooty/photonvision that referenced this pull request Dec 22, 2025
@samfreund @spacey-sooty
Add support for building rubik image (PhotonVision#2110)
c59bbb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcm001 mcm001 mcm001 approved these changes

@Gold856 Gold856 Awaiting requested review from Gold856

@crschardt crschardt Awaiting requested review from crschardt

Assignees

No one assigned

Labels

documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rubik PI 3 Image

3 participants

@samfreund @mcm001 @crschardt